Skip to content

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Sep 8, 2025

Required for: cylc/cylc-ui#2299

We have a functionality gap for the case where we want to broadcast to a historical cycle before re-triggering it because the broadcast will be expired before the cycle can be triggered.

The --on-resume option handled this, so we need a workaround before removing it.

Minor change: don't auto-expire broadcasts whilst the scheduler is paused.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at improve broadcast documentation cylc-doc#871
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the 8.6.0 milestone Sep 8, 2025
@oliver-sanders oliver-sanders self-assigned this Sep 8, 2025
@hjoliver
Copy link
Member

hjoliver commented Sep 8, 2025

See #6974 (comment)

@hjoliver
Copy link
Member

hjoliver commented Sep 8, 2025

Somewhat ironically, this solution would have allowed us to keep the short expiry interval - or even have past broadcasts expire immediately. The rule would be, if you need to broadcast to past tasks, pause the workflow, trigger, then resume.

@MetRonnie MetRonnie self-requested a review September 10, 2025 08:48
* Don't auto-expire broadcasts in a paused scheduler.
* This allows historical cycles to be broadcasted and triggered.
* Answering the remaining use case for the `--on-resume` option
  - cylc/cylc-ui#2299
@oliver-sanders oliver-sanders force-pushed the broadcast.dont_auto_expire_whilst_paused branch from 79c9c25 to c43f137 Compare September 10, 2025 09:23
@oliver-sanders
Copy link
Member Author

(docs rolled into cylc/cylc-doc#871)

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One code comment suggestion from Hilary still unresolved

Co-authored-by: Hilary James Oliver <[email protected]>
@wxtim wxtim merged commit 39f5fc9 into cylc:master Sep 22, 2025
17 of 19 checks passed
@oliver-sanders oliver-sanders deleted the broadcast.dont_auto_expire_whilst_paused branch September 23, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants